lbradstreet commented on a change in pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#discussion_r454587462
##########
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest extends
KafkaServerTestHarness with Loggin
adminClient.createTopics(
Collections.singletonList(new NewTopic(testTopicName, partitions,
replicationFactor).configs(configMap))).all().get()
waitForTopicCreated(testTopicName)
- TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
10, acks = -1)
+ TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
1000, acks = -1)
val brokerIds = servers.map(_.config.brokerId)
- TestUtils.setReplicationThrottleForPartitions(adminClient, brokerIds,
Set(tp), throttleBytes = 1)
Review comment:
Why did we remove this? We still need the throttle to be set so that the
replica doesn't join the ISR. It could easily do this even if it only fetches a
message at a time. The idea with the new replica fetch max bytes setting is to
give the broker a chance to throttle itself before joining the ISR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
