lbradstreet commented on a change in pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#discussion_r454589063
##########
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest extends
KafkaServerTestHarness with Loggin
adminClient.createTopics(
Collections.singletonList(new NewTopic(testTopicName, partitions,
replicationFactor).configs(configMap))).all().get()
waitForTopicCreated(testTopicName)
- TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
10, acks = -1)
+ TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
1000, acks = -1)
Review comment:
With the throttle approach we don't want it to be produced in a single
batch. If all messages are produced in a single batch then you will still fetch
the entire batch in a single request even if replica.fetch.max.bytes is 1, as
we allow this limit to be broken to fetch at least one message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
