vvcephei commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-663631102
Hey @mjsax , Since Streams accounted for almost all of the `System.exit` calls, and since `Exit.exit` is available almost everywhere in AK, I'm proposing to add a checkstyle rule forbidding it. The violation will look like this: ``` [ant:checkstyle] [ERROR] /home/confluent/kafka/clients/src/main/java/org/apache/kafka/some/BadClass.java:43: Line matches the illegal pattern ''System.exit': Should not directly call System.exit, but Exit.exit instead.'. [Regexp] ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
