lbradstreet commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-663689440
> Hey @mjsax , > > I double-checked, and it does seem to be the right fix. I confirmed that no matter whether you run the test with IDEA or gradle, there's nothing to automatically set the exit procedure, so `Exit.exit` is equivalent to `System.exit` unless a test specifically overrides the exit procedure, as I have done here. > > Nevertheless, I see no reason not to also take your advice and just replace all calls to `System.exit` with `Exit.exit`. Since `Exit` is provided as a utility in the main Client module, it's available in every context in which Streams is available. Note, this by itself won't fix anything. If a test calls `Exit.exit`, it will fail with the reported error unless it overrides the exit procedure. > > I did my best to trace all call paths that end in `exit()`, and still `SmokeTestDriverIntegrationTest` is the only one that I found. Right, you'll need ```Exit.setExitProcedure((_, _) => doSomething())``` to be setup somewhere to override the Exit.exit behavior, otherwise it will still do the same thing as it did before. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
