chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463066191
##########
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
}
}
+ /**
+ * @return Returning a map of successfully appended topic partitions and a
flag indicting whether the HWM has been
+ * incremented. The caller ought to complete delayed requests for
those returned partitions.
+ */
def storeGroup(group: GroupMetadata,
groupAssignment: Map[String, Array[Byte]],
- responseCallback: Errors => Unit): Unit = {
+ responseCallback: Errors => Unit): Map[TopicPartition,
LeaderHwChange] = {
Review comment:
The response was
https://github.com/apache/kafka/pull/8657#discussion_r452754165
In short, we should have a way of fetching delayed request from partition
instead of using return value to carry them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
