[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

[GitBox]

ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463291268



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##########
@@ -668,6 +671,9 @@ private void checkKeyValueStoreMetrics(final String 
group0100To24,
         checkMetricByName(listMetricStore, SUPPRESSION_BUFFER_SIZE_CURRENT, 0);
         checkMetricByName(listMetricStore, SUPPRESSION_BUFFER_SIZE_AVG, 0);
         checkMetricByName(listMetricStore, SUPPRESSION_BUFFER_SIZE_MAX, 0);
+        checkMetricByName(listMetricStore, RECORD_E2E_LATENCY_AVG, 
expectedNumberofE2ELatencyMetrics);
+        checkMetricByName(listMetricStore, RECORD_E2E_LATENCY_MIN, 
expectedNumberofE2ELatencyMetrics);
+        checkMetricByName(listMetricStore, RECORD_E2E_LATENCY_MAX, 
expectedNumberofE2ELatencyMetrics);

Review comment:
       Hm, if I let additional metrics through (by allowing all 
`STATE_STORE_LEVEL_GROUP` metrics regardless of buildInMetricsVersion) then the 
test fails much earlier. For example
   ```java.lang.AssertionError: Size of metrics of type:'put-latency-avg' must 
be equal to 1 but it's equal to 3 ```
   
   I think I could just do the check for the e2e latency before filtering, but 
I'm worried there's something else wrong here. Why do we get 3 
`put-latency-avg` metrics if we let all store metrics through in 
`checkKeyValueStoreMetrics` but not when we let all metrics through in 
`checkWindowStoreAndSuppressionBufferMetrics`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org