[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

[GitBox]

ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463312310



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -468,38 +468,44 @@ public void 
shouldRecordE2ELatencyOnProcessForSourceNodes() {
     }
 
     @Test
-    public void shouldRecordE2ELatencyMinAndMax() {
+    public void shouldRecordE2ELatencyAvgAndMinAndMax() {
         time = new MockTime(0L, 0L, 0L);
         metrics = new Metrics(new 
MetricConfig().recordLevel(Sensor.RecordingLevel.INFO), time);
         task = createStatelessTask(createConfig(false, "0"), 
StreamsConfig.METRICS_LATEST);
 
         final String sourceNode = source1.name();
 
-        final Metric maxMetric = getProcessorMetric("record-e2e-latency", 
"%s-max", task.id().toString(), sourceNode, StreamsConfig.METRICS_LATEST);
+        final Metric avgMetric = getProcessorMetric("record-e2e-latency", 
"%s-avg", task.id().toString(), sourceNode, StreamsConfig.METRICS_LATEST);
         final Metric minMetric = getProcessorMetric("record-e2e-latency", 
"%s-min", task.id().toString(), sourceNode, StreamsConfig.METRICS_LATEST);
+        final Metric maxMetric = getProcessorMetric("record-e2e-latency", 
"%s-max", task.id().toString(), sourceNode, StreamsConfig.METRICS_LATEST);
 
+        assertThat(avgMetric.metricValue(), equalTo(Double.NaN));
         assertThat(minMetric.metricValue(), equalTo(Double.NaN));
         assertThat(maxMetric.metricValue(), equalTo(Double.NaN));
 
         // e2e latency = 10
         task.maybeRecordE2ELatency(0L, 10L, sourceNode);

Review comment:
       Ack




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org