mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r465324629
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -477,7 +484,7 @@ private boolean checkMetadataVersions(final int
minReceivedMetadataVersion,
* @return map from repartition topic to its partition info
*/
private Map<TopicPartition, PartitionInfo> prepareRepartitionTopics(final
Map<Integer, TopicsInfo> topicGroups,
-
final Cluster metadata) {
+
final Cluster metadata) throws TaskAssignmentException {
Review comment:
`TaskAssignmentException` is not a checked exception and it's just a
curtesy declaration... (I can also remove `throws TaskAssignmentException` if
you prefer).
Don't see any need to document anything further -- the code makes it clear
(in fact, this method does not even throw the exception itself, but it just
bubbles up from `internalTopicManager.makeReady`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
