abbccdda commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r465999685
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -373,8 +373,15 @@ public GroupAssignment assign(final Cluster metadata,
final GroupSubscription gr
final Set<TaskId> statefulTasks = new HashSet<>();
- final boolean probingRebalanceNeeded =
- assignTasksToClients(fullMetadata, allSourceTopics, topicGroups,
clientMetadataMap, partitionsForTask, statefulTasks);
+ final boolean probingRebalanceNeeded;
+ try {
+ probingRebalanceNeeded = assignTasksToClients(fullMetadata,
allSourceTopics, topicGroups, clientMetadataMap, partitionsForTask,
statefulTasks);
+ } catch (final TaskAssignmentException | TimeoutException e) {
+ return new GroupAssignment(
Review comment:
Since we could throw different exceptions here, would be good to add a
log to indicate which type of exception is thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
