rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r466681231
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##########
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable) {
return new
AlterClientQuotasResult(Collections.unmodifiableMap(futures));
}
+ @Override
+ public DescribeUserScramCredentialsResult
describeUserScramCredentials(List<String> users,
DescribeUserScramCredentialsOptions options) {
+ final KafkaFutureImpl<Map<String, UserScramCredentialsDescription>>
future = new KafkaFutureImpl<>();
+ final long now = time.milliseconds();
+ Call call = new Call("describeUserScramCredentials",
calcDeadlineMs(now, options.timeoutMs()),
+ new ControllerNodeProvider()) {
Review comment:
The KIP says `It will be will be sent to the controller, and will return
NOT_CONTROLLER if the receiving broker is not the controller.` It says this for
both Describe and Alter. I agree it doesn't seem necessary for Describe.
Would it require an email to the list for notification if we decide to change
it? Or would a KIP update be sufficient? Do you think we should change it?
@cmccabe any thoughts here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
