rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r467191680
##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -508,7 +563,15 @@ object ConfigCommand extends Config {
val entityStr = (entitySubstr(ClientQuotaEntity.USER) ++
entitySubstr(ClientQuotaEntity.CLIENT_ID)).mkString(", ")
val entriesStr = entries.asScala.map(e =>
s"${e._1}=${e._2}").mkString(", ")
- println(s"Configs for ${entityStr} are ${entriesStr}")
+ println(s"Quota configs for ${entityStr} are ${entriesStr}")
+ }
+ // we describe user SCRAM credentials only when we are not describing
client information
+ // and we are not given either --entity-default or --user-defaults
+ if (!entityTypes.contains(ConfigType.Client) && !entityNames.contains(""))
{
+ getUserScramCredentialConfigs(adminClient, entityNames).foreach { case
(user, description) =>
Review comment:
I'm adding
`core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala` --
let me know if this test covers this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
