mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r470063833
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -485,13 +490,11 @@ class Partition(val topicPartition: TopicPartition,
def makeLeader(partitionState: LeaderAndIsrPartitionState,
Review comment:
I don't think AlterIsr changes anything since we're now just sending the
async ISR update where we were previously directly updating ZK.
Looking at the usages, `updateFollowerFetchState` is only called following a
read (`Partition#readRecords`). These reads only happen on fetch requests and
from the alter log dirs fetcher. I'm not sure about the alter log dirs flow,
but as long as it sends the leader epoch, it should be safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
