mumrah commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r470678123
##########
File path: core/src/main/scala/kafka/cluster/Partition.scala
##########
@@ -255,6 +255,10 @@ class Partition(val topicPartition: TopicPartition,
def isAddingReplica(replicaId: Int): Boolean =
assignmentState.isAddingReplica(replicaId)
+ // For advancing the HW we assume the largest ISR even if the controller
hasn't made the change yet
+ // This set includes the latest ISR (as we learned from LeaderAndIsr) and
any replicas from a pending ISR expansion
+ def effectiveInSyncReplicaIds: Set[Int] = inSyncReplicaIds |
pendingInSyncReplicaIds
Review comment:
Since we are now only allowing one in-flight AlterIsr, I changed the
semantics of pendingInSyncReplicaIds to be the maximal "effective" ISR. This
way we don't need to compute it each time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
