[ 
https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180811#comment-17180811
 ] 

Guozhang Wang commented on KAFKA-10410:
---------------------------------------

Hello [~markshelton], thanks for reporting this.

Yes this is a by-design fix to decouple the stateRestoreCallback (which is used 
for just applying records read from changelogs to state stores, per store) from 
stateRestoreListener (used for indicating the beginning / end / etc during 
restoration, global) since originally they was merged in a hacky way to just 
enable certain rocksDB optimization which turns out to have other side effects.

Could you let me know why you cannot set the state restore listener through 
`KafkaStreams#setGlobalStateRestoreListener`? Maybe I can try to figure out 
something to unblock you.

> OnRestoreStart disappeared from StateRestoreCallback  in 2.6.0 and reappeared 
> in a useless place
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-10410
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10410
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 2.6.0
>            Reporter: Mark Shelton
>            Priority: Blocker
>
> In version 2.5.0 and earlier there are "onRestoreStart" and "onRestoreEnd" 
> methods on StateRestoreCallback.
> Version 2.6.0 removed these calls and put them into StateRestoreListener and 
> requires "streaming.setGlobalStateRestoreListener".
> This makes it impossible for the actual StateRestoreCallback implementation 
> to receive the start and end indication and is blocking me from moving to 
> 2.6.0.
> See:
> [https://kafka.apache.org/25/javadoc/index.html?org/apache/kafka/streams/processor/AbstractNotifyingRestoreCallback.html]
>  
> Related JIRA:
> https://issues.apache.org/jira/browse/KAFKA-4322 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to