[
https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185511#comment-17185511
]
Sophie Blee-Goldman commented on KAFKA-10410:
---------------------------------------------
It's hard to say without knowing specifically what happens in your
StateRestoreCallback, but handling transactions with the StateRestoreListener
sounds potentially unsafe: even before 2.6, `onRestoreEnd` was never guaranteed
to be called when a store stopped restoring, only when the restoration actually
completed (onRestoreComplete would have been a better name). So it was always
possible for onRestoreStart to be called without ever calling onRestoreEnd, or
for onRestoreStart to be called multiple times in a row, etc
That said, can't you just register the callback of each store+partition to your
global restore listener, then use the handle on the callback to do whatever
cleanup you needed for that particular store when onRestoreEnd is called for
it? It's certainly a bit roundabout, but definitely still possible
> OnRestoreStart disappeared from StateRestoreCallback in 2.6.0 and reappeared
> in a useless place
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-10410
> URL: https://issues.apache.org/jira/browse/KAFKA-10410
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 2.6.0
> Reporter: Mark Shelton
> Priority: Blocker
>
> In version 2.5.0 and earlier there are "onRestoreStart" and "onRestoreEnd"
> methods on StateRestoreCallback.
> Version 2.6.0 removed these calls and put them into StateRestoreListener and
> requires "streaming.setGlobalStateRestoreListener".
> This makes it impossible for the actual StateRestoreCallback implementation
> to receive the start and end indication and is blocking me from moving to
> 2.6.0.
> See:
> [https://kafka.apache.org/25/javadoc/index.html?org/apache/kafka/streams/processor/AbstractNotifyingRestoreCallback.html]
>
> Related JIRA:
> https://issues.apache.org/jira/browse/KAFKA-4322
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
