chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-681318790


   > We keep DelayedJoin as it is, still passing in the group lock to 
DelayedOperation to avoid deadlocks due to two levels of locking.
   
   Just double check. We use a separate thread to handle 
```groupManager.storeGroup``` and ```joinPurgatory.tryCompleteElseWatch``` in 
```GroupCoordinator.onCompleteJoin```, right? 
```GroupCoordinator.onCompleteJoin``` is called by ```DelayedJoin.onComplete``` 
only and it is possible to hold a group lock already.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to