chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-683434648
> Could you do some perf tests so that we know the performance of fetch requests doesn't change noticeably? the result of ```Benchmark.test_producer_and_consumer``` is attached below. It seems the patch gets better throughput :) I will run more performance tests tomorrow. **BEFORE** ``` test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.2.security_protocol=SSL.compression_type=none status: PASS run time: 1 minute 8.041 seconds {"consumer": {"records_per_sec": 570060.4264, "mb_per_sec": 54.3652}, "producer": {"records_per_sec": 611583.389395, "mb_per_sec": 58.33}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.2.security_protocol=SSL.compression_type=snappy status: PASS run time: 58.549 seconds {"consumer": {"records_per_sec": 1331203.4079, "mb_per_sec": 126.9535}, "producer": {"records_per_sec": 1257387.149503, "mb_per_sec": 119.91}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.3.security_protocol=SSL.compression_type=none status: PASS run time: 1 minute 7.757 seconds {"consumer": {"records_per_sec": 577133.9528, "mb_per_sec": 55.0398}, "producer": {"records_per_sec": 582106.059724, "mb_per_sec": 55.51}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.3.security_protocol=SSL.compression_type=snappy status: PASS run time: 59.287 seconds {"consumer": {"records_per_sec": 1421868.335, "mb_per_sec": 135.5999}, "producer": {"records_per_sec": 1332267.519318, "mb_per_sec": 127.05}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.security_protocol=PLAINTEXT.compression_type=none status: PASS run time: 1 minute 1.819 seconds {"consumer": {"records_per_sec": 987361.7694, "mb_per_sec": 94.1622}, "producer": {"records_per_sec": 942862.530643, "mb_per_sec": 89.92}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.security_protocol=PLAINTEXT.compression_type=snappy status: PASS run time: 55.877 seconds {"consumer": {"records_per_sec": 1479508.8031, "mb_per_sec": 141.097}, "producer": {"records_per_sec": 1339046.598822, "mb_per_sec": 127.7}} -------------------------------------------------------------------------------- ``` **AFTER** ``` test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.2.security_protocol=SSL.compression_type=none status: PASS run time: 1 minute 9.619 seconds {"consumer": {"records_per_sec": 615422.4875, "mb_per_sec": 58.6913}, "producer": {"records_per_sec": 640779.187492, "mb_per_sec": 61.11}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.2.security_protocol=SSL.compression_type=snappy status: PASS run time: 57.667 seconds {"consumer": {"records_per_sec": 1444043.3213, "mb_per_sec": 137.7147}, "producer": {"records_per_sec": 1398014.818957, "mb_per_sec": 133.33}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.3.security_protocol=SSL.compression_type=none status: PASS run time: 1 minute 6.802 seconds {"consumer": {"records_per_sec": 619770.6848, "mb_per_sec": 59.1059}, "producer": {"records_per_sec": 646203.55412, "mb_per_sec": 61.63}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.interbroker_security_protocol=PLAINTEXT.tls_version=TLSv1.3.security_protocol=SSL.compression_type=snappy status: PASS run time: 1 minute 0.790 seconds {"consumer": {"records_per_sec": 1484119.9169, "mb_per_sec": 141.5367}, "producer": {"records_per_sec": 1403902.849923, "mb_per_sec": 133.89}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.security_protocol=PLAINTEXT.compression_type=none status: PASS run time: 1 minute 0.074 seconds {"consumer": {"records_per_sec": 916422.2874, "mb_per_sec": 87.3968}, "producer": {"records_per_sec": 941796.948578, "mb_per_sec": 89.82}} -------------------------------------------------------------------------------- test_id: kafkatest.benchmarks.core.benchmark_test.Benchmark.test_producer_and_consumer.security_protocol=PLAINTEXT.compression_type=snappy status: PASS run time: 57.799 seconds {"consumer": {"records_per_sec": 1414027.1493, "mb_per_sec": 134.8521}, "producer": {"records_per_sec": 1330671.989355, "mb_per_sec": 126.9}} -------------------------------------------------------------------------------- ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org