jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r481931127
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java
##########
@@ -117,12 +118,20 @@ public void openExisting(final ProcessorContext context,
final long streamTime)
}
@Override
- public List<S> segments(final long timeFrom, final long timeTo) {
+ public List<S> segments(final long timeFrom, final long timeTo, final
boolean forward) {
final List<S> result = new ArrayList<>();
- final NavigableMap<Long, S> segmentsInRange = segments.subMap(
- segmentId(timeFrom), true,
- segmentId(timeTo), true
- );
+ final NavigableMap<Long, S> segmentsInRange;
+ if (forward) {
Review comment:
I'd prefer this immutable approach as it's the same used in
keyValueStore changes, if that's ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
