jeqo commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r482160020
##########
File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java
##########
@@ -150,13 +185,25 @@
* @return an iterator over windowed key-value pairs {@code <Windowed<K>,
value>}
* @throws InvalidStateStoreException if the store is not initialized
*/
- @SuppressWarnings("deprecation") // note, this method must be kept if
super#fetchAll(...) is removed
+ // note, this method must be kept if super#fetchAll(...) is removed
+ @SuppressWarnings("deprecation")
KeyValueIterator<Windowed<K>, V> fetchAll(long timeFrom, long timeTo);
@Override
- default KeyValueIterator<Windowed<K>, V> fetchAll(final Instant from,
final Instant to) {
+ default KeyValueIterator<Windowed<K>, V> fetchAll(final Instant timeFrom,
final Instant timeTo) {
return fetchAll(
- ApiUtils.validateMillisecondInstant(from,
prepareMillisCheckFailMsgPrefix(from, "from")),
- ApiUtils.validateMillisecondInstant(to,
prepareMillisCheckFailMsgPrefix(to, "to")));
+ ApiUtils.validateMillisecondInstant(timeFrom,
prepareMillisCheckFailMsgPrefix(timeFrom, "timeFrom")),
+ ApiUtils.validateMillisecondInstant(timeTo,
prepareMillisCheckFailMsgPrefix(timeTo, "timeTo")));
+ }
+
+ default KeyValueIterator<Windowed<K>, V> backwardFetchAll(final long
timeFrom, final long timeTo) {
Review comment:
@guozhangwang do you mean the changes proposed in KIP-667? In that KIP
we are removing long-based methods only from `ReadOnlyWindowStore`, but will
keep it in `WindowStore`—unless you're referring to a different proposal.
I do agree with @ableegoldman. Users will have to opt-in to reverse
operations when using custom stores, and by default only add implementation for
long-based to support both params options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
