scanterog commented on a change in pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#discussion_r497079320
##########
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -199,8 +199,8 @@
protected static final String SOURCE_CLUSTER_PREFIX =
MirrorMakerConfig.SOURCE_CLUSTER_PREFIX;
protected static final String TARGET_CLUSTER_PREFIX =
MirrorMakerConfig.TARGET_CLUSTER_PREFIX;
- protected static final String PRODUCER_CLIENT_PREFIX = "producer.";
- protected static final String CONSUMER_CLIENT_PREFIX = "consumer.";
+ protected static final String PRODUCER_CLIENT_PREFIX =
SOURCE_CLUSTER_PREFIX + "producer.";
+ protected static final String CONSUMER_CLIENT_PREFIX =
SOURCE_CLUSTER_PREFIX + "consumer.";
Review comment:
I have put a new fix that should handle both cases. Details on why I
think this is a reasonable fix:
* There's no change on was is defined
[here](https://github.com/apache/kafka/tree/trunk/connect/mirror#producer--consumer--admin-config-used-by-mm2).
The properties that starts with `producer.` or `consumer.` are still ignored
in mm2 dedicated mode.
* MM2 needs to differentiate the properties for the source cluster and we
can't just remove the `source.cluster` prefix.
* For running the mirror connectors on a Connect cluster, the only
"drawback" is that now you can provide an override with
`source.cluster.consumer` or `source.cluster.producer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
