mimaison commented on a change in pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#discussion_r500562684
##########
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -199,8 +199,8 @@
protected static final String SOURCE_CLUSTER_PREFIX =
MirrorMakerConfig.SOURCE_CLUSTER_PREFIX;
protected static final String TARGET_CLUSTER_PREFIX =
MirrorMakerConfig.TARGET_CLUSTER_PREFIX;
- protected static final String PRODUCER_CLIENT_PREFIX = "producer.";
- protected static final String CONSUMER_CLIENT_PREFIX = "consumer.";
+ protected static final String PRODUCER_CLIENT_PREFIX =
SOURCE_CLUSTER_PREFIX + "producer.";
+ protected static final String CONSUMER_CLIENT_PREFIX =
SOURCE_CLUSTER_PREFIX + "consumer.";
Review comment:
I don't think the format mentioned in
https://github.com/apache/kafka/pull/9313#discussion_r498298987 would break
compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
