RamanVerma commented on a change in pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#discussion_r499718784



##########
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##########
@@ -4447,9 +4504,10 @@ class LogTest {
 
   private def recoverAndCheck(config: LogConfig,
                               expectedKeys: Iterable[Long],
-                              expectDeletedFiles: Boolean = true): Log = {
+                              expectDeletedFiles: Boolean = true,

Review comment:
       I think you meant the `hadCleanShutdown` parameter I added. I did not 
add the `expectDeletedFiles` parameter.
   I will remove the new parameter and add a comment here to indicate that the 
method always assumes we had a hard reset.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to