RamanVerma commented on a change in pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#discussion_r511545712
##########
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##########
@@ -2131,12 +2202,12 @@ class LogTest {
assertEquals("Should have same number of time index entries as before.",
numTimeIndexEntries, log.activeSegment.timeIndex.entries)
}
- log = createLog(logDir, logConfig, recoveryPoint = lastOffset)
+ log = createLog(logDir, logConfig, recoveryPoint = lastOffset,
lastShutdownClean = false)
Review comment:
Jun, this test was not creating a clean shut down file before opening
the log again. So, it would have gone through the recovery path. Hence, I have
set `lastShutdownClean` parameter to `false`. Similarly, for line 2210.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
