[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

[GitBox]

mjsax commented on a change in pull request #9384:
URL: https://github.com/apache/kafka/pull/9384#discussion_r500574894



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java
##########
@@ -203,8 +204,8 @@ public void 
shouldReturnAllActiveTasksToPreviousOwnerRegardlessOfBalanceAndTrigg
         builder.addStateStore(new MockKeyValueStoreBuilder("store1", false), 
"processor1");
         final Set<TaskId> allTasks = mkSet(TASK_0_0, TASK_0_1, TASK_0_2);
 
-        createMockTaskManager(allTasks);
         adminClient = EasyMock.createMock(AdminClient.class);
+        createMockTaskManager(allTasks);

Review comment:
       We need to setup the admin mock before the TM mock now (similar 
elsewhere)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org