mjsax commented on a change in pull request #9384:
URL: https://github.com/apache/kafka/pull/9384#discussion_r504909676
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -192,12 +191,11 @@ public String toString() {
*/
@Override
public void configure(final Map<String, ?> configs) {
- final AssignorConfiguration assignorConfiguration = new
AssignorConfiguration(configs);
+ assignorConfiguration = new AssignorConfiguration(configs);
Review comment:
I never intended to drop it. Maybe I miss understand your comment?
We could replace the field `StreamsParttionAssignor#taskManager` etc with
`StreamsPartitionAssigner#referenceContainer` but it just make the code lines
longer each time we need to access the TM (etc). Thus, it seems to make the
code more readable if we just "extract" those field from the reference
container once?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
