ableegoldman commented on a change in pull request #9446:
URL: https://github.com/apache/kafka/pull/9446#discussion_r505900644
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -330,75 +331,61 @@ public GroupAssignment assign(final Cluster metadata,
final GroupSubscription gr
clientMetadata.addPreviousTasksAndOffsetSums(consumerId,
info.taskOffsetSums());
}
- final boolean versionProbing =
- checkMetadataVersions(minReceivedMetadataVersion,
minSupportedMetadataVersion, futureMetadataVersion);
+ try {
Review comment:
The diff is kind of annoying but basically I just moved all the
try-catch blocks into a single outer try that encapsulates all of the
assignment logic. If we throw a TaskAssignmentException at any point it'll bail
and just encode the `ASSIGNMENT_ERROR` code (or
`INCOMPLETE_SOURCE_TOPIC_METADATA` if MissingSourceTopicException is thrown)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
