ableegoldman commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r506622465
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java ########## @@ -52,8 +53,11 @@ public void onPartitionsAssigned(final Collection<TopicPartition> partitions) { // NB: all task management is already handled by: // org.apache.kafka.streams.processor.internals.StreamsPartitionAssignor.onAssignment if (assignmentErrorCode.get() == AssignorError.INCOMPLETE_SOURCE_TOPIC_METADATA.code()) { - log.error("Received error code {}", assignmentErrorCode.get()); + log.error("Received error code {}", AssignorError.INCOMPLETE_SOURCE_TOPIC_METADATA); throw new MissingSourceTopicException("One or more source topics were missing during rebalance"); + } else if (assignmentErrorCode.get() == AssignorError.ASSIGNMENT_ERROR.code()) { + log.error("Received error code {}", AssignorError.ASSIGNMENT_ERROR); + throw new TaskAssignmentException("Hit an unexpected exception during task assignment phase of rebalance"); } Review comment: Ooh, but we did use to have a VERSION_PROBING error code that had value `2`. So we should skip that and go right to `3`, thanks for reminding me ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org