rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r511174838



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -770,7 +770,7 @@ class ReplicaManager(val config: KafkaConfig,
             logManager.abortAndPauseCleaning(topicPartition)
 
             val initialFetchState = 
InitialFetchState(BrokerEndPoint(config.brokerId, "localhost", -1),
-              partition.getLeaderEpoch, futureLog.highWatermark)
+              partition.getLeaderEpoch, futureLog.highWatermark, 
lastFetchedEpoch = None)

Review comment:
       Looking at this again, I think a bit more work is required to set the 
offsets and epoch correctly for AlterLogDirsThread in order to use 
`lastFetchedEpoch`. So I have reverted the changes for 
ReplicaAlterLogDirsThread. Will do that in a follow-on PR instead. In this PR, 
we will use the old truncation path in this case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to