[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

[GitBox]

wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r517621757



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -294,7 +304,10 @@ public static StreamThread create(final 
InternalTopologyBuilder builder,
                                       final long cacheSizeBytes,
                                       final StateDirectory stateDirectory,
                                       final StateRestoreListener 
userStateRestoreListener,
-                                      final int threadIdx) {
+                                      final int threadIdx,
+                                      final ShutdownErrorHook 
shutdownErrorHook,
+                                      final StreamsUncaughtExceptionHandler 
streamsUncaughtExceptionHandler,
+                                      final AtomicInteger assignmentErrorCode) 
{

Review comment:
       You are right it seems that it is not necessary 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org