abbccdda commented on a change in pull request #9564:
URL: https://github.com/apache/kafka/pull/9564#discussion_r523184916
##########
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala
##########
@@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(networkClient:
KafkaClient,
}
private[server] def handleResponse(request:
BrokerToControllerQueueItem)(response: ClientResponse): Unit = {
- if (response.wasDisconnected()) {
+ if (isTimedOut(response)) {
+ debug(s"The request failed to send to the controller after timeout
${clientRequestTimeout} ms: $response")
Review comment:
I think the `failExpiredRequests` in the InterBrokerSendThread level
shall be fired and reach the callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
