abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r525764228
########## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ########## @@ -178,6 +183,11 @@ class BrokerToControllerRequestThread(networkClient: KafkaClient, } } + private def isTimedOut(response: ClientResponse): Boolean = { + val requestCreatedTime = response.receivedTimeMs() - response.requestLatencyMs() Review comment: Is it legitimate to compare with requestTimeout here since we actually measure the request buffered time on the broker-to-controller channel queue? Should we introduce a new timeout config here somehow? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org