jsancio commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r523262141
##########
File path: core/src/main/scala/kafka/log/LogCleaner.scala
##########
@@ -711,6 +723,9 @@ private[log] class Cleaner(val id: Int,
shallowOffsetOfMaxTimestamp = result.shallowOffsetOfMaxTimestamp,
records = retained)
throttler.maybeThrottle(outputBuffer.limit())
+ if (newCanUpdateBaseOffset)
+ dest.updateBaseOffset(result.minOffset())
+ newCanUpdateBaseOffset = false
Review comment:
Okay. We can do this in a future PR if you like. Do you want to file an
issue for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
