[GitHub] [kafka] jsancio commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

[GitBox]

jsancio commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r523262472



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1306,7 +1309,7 @@ class Log(@volatile private var _dir: File,
     // in an unclean manner within 
log.flush.start.offset.checkpoint.interval.ms. The chance of this happening is 
low.
     maybeHandleIOException(s"Exception while increasing log start offset for 
$topicPartition to $newLogStartOffset in dir ${dir.getParent}") {
       lock synchronized {
-        if (newLogStartOffset > highWatermark)
+        if (reason != SegmentCompaction && newLogStartOffset > highWatermark)

Review comment:
       Okay. We can do this in a future PR if you like. Do you want to file an 
issue for this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org