[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

[GitBox]

wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r524437940



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##########
@@ -311,6 +314,8 @@ public void run() {
                 "Updating global state failed. You can restart KafkaStreams to 
recover from this error.",
                 recoverableException
             );
+        } catch (final Exception e) {
+            this.streamsUncaughtExceptionHandler.accept(e);

Review comment:
       +1 to sorting out FSM before next release, I have a ticket to track the 
work. I started to change it and it ballooned out to be much more expansive 
than I thought. This PR is already complicated enough, so we can add is later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org