wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r523334335
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##########
@@ -311,6 +314,8 @@ public void run() {
"Updating global state failed. You can restart KafkaStreams to
recover from this error.",
recoverableException
);
+ } catch (final Exception e) {
+ this.streamsUncaughtExceptionHandler.accept(e);
Review comment:
I don't think it will actually transition to `ERROR` because the handler
will call close before the global thread is dead, which will transition to
PEDING_SHUTDOWN, there is no transition to ERROR from either PENDING_SHUTDOWN
or NOT_RUNNING.
the FSM will be part of the add thread work as it doesn't really make sense
to remove the change to error until we can add threads
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
