gardnervickers commented on a change in pull request #9601:
URL: https://github.com/apache/kafka/pull/9601#discussion_r532249601
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/AlterReplicaLogDirsResponse.java
##########
@@ -38,10 +38,6 @@
private final AlterReplicaLogDirsResponseData data;
- public AlterReplicaLogDirsResponse(Struct struct) {
Review comment:
Having this override seemed a bit error prone, and was causing failures
for the `NetworkClientTest`. I opted to remove it entirely in favor of forcing
the caller to specify the response version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
