gardnervickers commented on a change in pull request #9601:
URL: https://github.com/apache/kafka/pull/9601#discussion_r532249943
##########
File path: core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala
##########
@@ -437,8 +437,8 @@ class ReplicaFetcherThreadTest {
thread.doWork()
assertEquals(2, mockNetwork.epochFetchCount)
assertEquals(1, mockNetwork.fetchCount)
- assertEquals("OffsetsForLeaderEpochRequest version.",
- 3, mockNetwork.lastUsedOffsetForLeaderEpochVersion)
+ assertTrue("OffsetsForLeaderEpochRequest version.",
+ mockNetwork.lastUsedOffsetForLeaderEpochVersion >= 3)
Review comment:
Admittedly I'm not sure why we check the version of the last
`OffsetForLeaderEpoch` response is 3 here. I decided to widen the check a bit
so this won't break for future versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
