[GitHub] [kafka] ijuma commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

[GitBox]

ijuma commented on a change in pull request #9732:
URL: https://github.com/apache/kafka/pull/9732#discussion_r541147023



##########
File path: 
clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java
##########
@@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffsetsToTxnRequestData 
data, short version) {
     }
 
     @Override
-    protected AddOffsetsToTxnRequestData data() {
+    public AddOffsetsToTxnRequestData data() {

Review comment:
       It seems like there are many classes where direct access to `data` is 
not actually needed. How do you feel about having a public method in 
`RequestUtils` that exposes `data` for the raft layer instead? Something like:
   
   ```java
   public static ApiMessage requestData(AbstractRequest req)
   public static ApiMessage responseData(AbstractResponse resp)
   ```
   
   Or is it not worth it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org