mjsax commented on a change in pull request #9800:
URL: https://github.com/apache/kafka/pull/9800#discussion_r552275624
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##########
@@ -408,9 +417,74 @@ public void shouldProcessInOrder() {
assertEquals(3, source2.numReceived);
}
+ @Test
+ public void shouldProcessRecordsAfterPrepareCommitWhenEosDisabled() {
+ task = createStatelessTask(createConfig(),
StreamsConfig.METRICS_LATEST);
+
+ assertFalse(task.process(time.milliseconds()));
+
+ task.addRecords(partition1, asList(
+ getConsumerRecord(partition1, 10),
+ getConsumerRecord(partition1, 20),
+ getConsumerRecord(partition1, 30)
+ ));
+
+ assertTrue(task.process(time.milliseconds()));
+ task.prepareCommit();
+ assertTrue(task.process(time.milliseconds()));
+ task.postCommit(false);
+ assertTrue(task.process(time.milliseconds()));
+
+ assertFalse(task.process(time.milliseconds()));
+ }
+
+ @Test
+ public void shouldNotProcessRecordsAfterPrepareCommitWhenEosAlphaEnabled()
{
+ task = createStatelessTask(createConfig(StreamsConfig.EXACTLY_ONCE,
"0"), StreamsConfig.METRICS_LATEST);
+
+ assertFalse(task.process(time.milliseconds()));
+
+ task.addRecords(partition1, asList(
+ getConsumerRecord(partition1, 10),
+ getConsumerRecord(partition1, 20),
+ getConsumerRecord(partition1, 30)
+ ));
+
+ assertTrue(task.process(time.milliseconds()));
+ task.prepareCommit();
+ assertFalse(task.process(time.milliseconds()));
+ task.postCommit(false);
+ assertTrue(task.process(time.milliseconds()));
+ assertTrue(task.process(time.milliseconds()));
Review comment:
We need to call `process()` twice here. We have 3 input records, and
want to confirm that all three are processed. If we don't call `process()` two
times here, the assert in L460 below would not return `false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
