chia7712 commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r558465841
##########
File path:
core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala
##########
@@ -43,20 +41,27 @@ import scala.jdk.CollectionConverters._
* Also tests the Alter and Describe APIs for the case where credentials are
successfully altered/described.
*/
class AlterUserScramCredentialsRequestTest extends BaseRequestTest {
+
+ private[this] var className =
classOf[AlterCredentialsTest.TestPrincipalBuilderReturningAuthorized].getName
+
+ override def setUp(): Unit = {
+ // do nothing as we will setup cluster by 'before'
+ }
+
+ @BeforeEach
+ def before(info: TestInfo): Unit = {
+ if (info.getDisplayName.contains("NotAuthorized"))
Review comment:
It required to override the properties of starting server according to
method name. You are right, current code is weird so I will separate the tests
which need different props to another file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
