ijuma commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r559255133



##########
File path: 
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala
##########
@@ -325,11 +315,9 @@ class 
LogCleanerParameterizedIntegrationTest(compressionCodec: String) extends A
 }
 
 object LogCleanerParameterizedIntegrationTest {
-  @Parameters
-  def parameters: java.util.Collection[Array[String]] = {
-    val list = new java.util.ArrayList[Array[String]]()
-    for (codec <- CompressionType.values)
-      list.add(Array(codec.name))
-    list
-  }
+  def all: java.util.stream.Stream[Arguments] =
+    java.util.Arrays.stream(CompressionType.values.map(codec => 
Arguments.of(codec)))
+
+  def excludeZstd: java.util.stream.Stream[Arguments] =

Review comment:
       Nit: even though this is technically true, it doesn't seem to capture 
the reason why we exclude zstd. It seems like we basically want to generate the 
compression types supported by V0 and V1 in this method. That would work better 
if we add more compression types in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to