hachikuji commented on a change in pull request #9934:
URL: https://github.com/apache/kafka/pull/9934#discussion_r562150161
##########
File path: core/src/main/scala/kafka/Kafka.scala
##########
@@ -65,11 +65,12 @@ object Kafka extends Logging {
private def buildServer(props: Properties): Server = {
val config = KafkaConfig.fromProps(props, false)
- if (config.processRoles.isEmpty) {
+ if (config.requiresZookeeper) {
Review comment:
Hmm `requiresZookeeper` seemed more explicit. I thought using
`processRoles` was a little obscure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
