abbccdda commented on a change in pull request #9934:
URL: https://github.com/apache/kafka/pull/9934#discussion_r562048902
##########
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##########
@@ -116,8 +116,8 @@
/** indicates the minimum required inter broker magic required to support
the API */
public final byte minRequiredInterBrokerMagic;
- /** indicates whether the API is enabled and should be exposed in
ApiVersions **/
- public final boolean isEnabled;
+ /** indicates whether this is an API which is only exposed by the KIP-500
controller **/
+ public final boolean isControllerOnlyApi;
Review comment:
Could we get a JIRA to track the work for refactoring these boolean
flags into static collections of api keys? To me it is not easy to use
constructor correctly when there are multiple of them.
##########
File path: raft/README.md
##########
@@ -12,17 +12,14 @@ Below we describe the details to set this up.
bin/test-raft-server-start.sh config/raft.properties
### Run Multi Node Quorum ###
-Create 3 separate raft quorum properties as the following
Review comment:
Do we need to define `process.roles` here?
##########
File path: core/src/main/scala/kafka/Kafka.scala
##########
@@ -65,11 +65,12 @@ object Kafka extends Logging {
private def buildServer(props: Properties): Server = {
val config = KafkaConfig.fromProps(props, false)
- if (config.processRoles.isEmpty) {
+ if (config.requiresZookeeper) {
Review comment:
What if we call `processRoles.isDefined` here?
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1876,5 +1874,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
Boolean, dynamicConfigO
s"${KafkaConfig.FailedAuthenticationDelayMsProp}=$failedAuthenticationDelayMs
should always be less than" +
s" ${KafkaConfig.ConnectionsMaxIdleMsProp}=$connectionsMaxIdleMs to
prevent failed" +
s" authentication responses from timing out")
+
+ if (requiresZookeeper && zkConnect == null) {
Review comment:
Do we have test coverage for this check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
