mjsax commented on a change in pull request #10000:
URL: https://github.com/apache/kafka/pull/10000#discussion_r566621619
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -227,6 +230,27 @@ public void initializeIfNeeded() {
}
}
+ private void initOffsetsIfNeeded(final
java.util.function.Consumer<Set<TopicPartition>> offsetResetter) {
+ final Map<TopicPartition, OffsetAndMetadata> committed =
mainConsumer.committed(resetOffsetsForPartitions);
+ for (final Map.Entry<TopicPartition, OffsetAndMetadata> committedEntry
: committed.entrySet()) {
+ final OffsetAndMetadata offsetAndMetadata =
committedEntry.getValue();
+ if (offsetAndMetadata != null) {
+ mainConsumer.seek(committedEntry.getKey(), offsetAndMetadata);
+ resetOffsetsForPartitions.remove(committedEntry.getKey());
+ }
+ }
+
+ if (!resetOffsetsForPartitions.isEmpty()) {
Review comment:
this `if` is not strictly required, however, it allows us to just pass
`null` as `offsetResetter` in tests, so might be worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
