ableegoldman commented on a change in pull request #10000:
URL: https://github.com/apache/kafka/pull/10000#discussion_r571317298
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -229,17 +231,22 @@ public void initializeIfNeeded() {
}
}
+ public void addPartitionsForOffsetReset(final Set<TopicPartition>
partitionsForOffsetReset) {
+ mainConsumer.pause(partitionsForOffsetReset);
+ resetOffsetsForPartitions.addAll(partitionsForOffsetReset);
+ }
+
/**
* @throws TimeoutException if fetching committed offsets timed out
*/
@Override
- public void completeRestoration() {
+ public void completeRestoration(final
java.util.function.Consumer<Set<TopicPartition>> offsetResetter) {
switch (state()) {
case RUNNING:
return;
case RESTORING:
- initializeMetadata();
+ resetOffsetsIfNeededAndInitializeMetadata(offsetResetter);
Review comment:
cool, thanks, this seems much cleaner to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
