rondagostino commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r569600606
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -256,9 +254,10 @@ class LogManager(logDirs: Seq[File],
private[log] def loadLog(logDir: File,
hadCleanShutdown: Boolean,
recoveryPoints: Map[TopicPartition, Long],
- logStartOffsets: Map[TopicPartition, Long]): Log = {
+ logStartOffsets: Map[TopicPartition, Long],
+ topicLogConfigs: Map[String, LogConfig]): Log = {
val topicPartition = Log.parseTopicPartitionName(logDir)
- val config = topicConfigs.getOrElse(topicPartition.topic,
currentDefaultConfig)
+ val config = topicLogConfigs.getOrElse(topicPartition.topic,
currentDefaultConfig)
Review comment:
We can ignore any topic that has no explicit configs in `startup()`
below since this is doing `.getOrElse()` -- it'll save memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
