rondagostino commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r571470926
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -352,13 +348,15 @@ class LogManager(logDirs: Seq[File],
val numLogsLoaded = new AtomicInteger(0)
numTotalLogs += logsToLoad.length
- val jobsForDir = logsToLoad.map { logDir =>
+ val jobsForDir = logsToLoad
+ .filter(logDir => Log.parseTopicPartitionName(logDir).topic !=
KafkaRaftServer.MetadataTopic)
Review comment:
I suspect we shouldn’t load topic configs on-demand because it would
change the current behavior. Specifically, if we can’t load the configs,
currently the object instantiation will raise an exception. The current patch
will cause the exception to be raised in startup(), which is effectively the
same thing. But if we load them on-demand then both instantiation and
startup() will succeed, and the exception will occur in a thread doing recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
