tombentley commented on a change in pull request #10004:
URL: https://github.com/apache/kafka/pull/10004#discussion_r570162199
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -591,7 +591,7 @@ public void handle(JoinGroupResponse joinResponse,
RequestFuture<ByteBuffer> fut
joinResponse.data().generationId(),
joinResponse.data().memberId(),
joinResponse.data().protocolName());
- log.info("Successfully joined group with
generation {}", AbstractCoordinator.this.generation);
+ log.info("Successfully joined group with
generation {} and memberId {}", generation.generationId, generation.memberId);
Review comment:
If we're removing the redundant `AbstractCoordinator.this` here, we
might as well do it 4 lines above too, imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
