dajac commented on a change in pull request #10004:
URL: https://github.com/apache/kafka/pull/10004#discussion_r575351558
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -591,7 +591,7 @@ public void handle(JoinGroupResponse joinResponse,
RequestFuture<ByteBuffer> fut
joinResponse.data().generationId(),
joinResponse.data().memberId(),
joinResponse.data().protocolName());
- log.info("Successfully joined group with
generation {}", AbstractCoordinator.this.generation);
+ log.info("Successfully joined group with
generation {} and memberId {}", generation.generationId, generation.memberId);
Review comment:
@nicolasguyomar We already log the memberId here as we log the entire
generation object (which includes the memberId). This was changed recently:
https://github.com/apache/kafka/commit/7e7bb184d2abe34280a7f0eb0f0d9fc0e32389f2#diff-15efe9b844f78b686393b6c2e2ad61306c3473225742caed05c7edab9a138832L504.
Previously, it was logging the generationId only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
