cmccabe commented on a change in pull request #10105:
URL: https://github.com/apache/kafka/pull/10105#discussion_r580571155
##########
File path: tests/kafkatest/tests/core/round_trip_fault_test.py
##########
@@ -47,32 +55,48 @@ def __init__(self, test_context):
active_topics=active_topics)
def setUp(self):
- self.zk.start()
+ if self.zk:
+ self.zk.start()
self.kafka.start()
self.trogdor.start()
def teardown(self):
self.trogdor.stop()
self.kafka.stop()
- self.zk.stop()
+ if self.zk:
+ self.zk.stop()
- def test_round_trip_workload(self):
+ def remote_quorum_nodes(self):
+ if quorum.for_test(self.test_context) == quorum.zk:
+ return self.zk.nodes
+ elif quorum.for_test(self.test_context) == quorum.remote_raft:
+ return self.kafka.controller_quorum.nodes
+ else: # co-located case, which we currently don't test but handle here
for completeness in case we do test it
+ return []
Review comment:
sounds good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
